-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite tracing support using the stats handler interface #1510
Comments
net/trace has such a bad implementation as well as grpc-go tracing decision. what is the point of registering debug handlers at package-init level? for customisation, there is nothing you can do. and grpc-go enables tracing default. there should be a better way to configure it, other than that mutating init level global variables. I think this is not suitable for a production use case, should be disabled by default. |
We agree; tracing was disabled by default in #1509. We may delete the global entirely and just provide a stats handler package the user can install if they want net/trace integration. |
#1434 would let you have more than one stats handler :) I've been having some trouble finding time to finish it off, maybe next week (or you can take it over if you want) |
Also, noticed that |
This issue is labeled as requiring an update from the reporter, and no update has been received after 7 days. If no update is provided in the next 7 days, this issue will be automatically closed. |
We have multiple monitoring features (channelz, stats handler, binary logging), and we are making a new API to unify all them (https://xkcd.com/927/) |
Support for multiple stats handler on the client and server was added as part of #5347. |
One notable problem here is that we can currently only install one stats handler at a time. This means we can't enable our default tracing and also let the user install a stats handler.
See also: #695
The text was updated successfully, but these errors were encountered: