-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This project is using internal-only protobuf APIs that may soon change namespaces or disappear. #35
Comments
Yes, we should talk. Once I understand the requirements better I can suggest a replacement. I want to clarify that these interfaces have always been internal, as evidenced by the fact that the files are in a directory called |
Just wanted to leave a note here about what we discussed a few weeks back. I think you were going to look into your uses of these APIs and see if they could be removed. If not, you can use an old version of protobuf once newer versions remove the internal APIs. |
Yes, that is what we have been agreed upon. |
FYI protobuf version 22.0 finally removed these internal APIs. It looks like grpc-httpjson-transcoding never migrated off them. So this project will need to continue using protobuf <22.0 until it can migrate off those APIs. |
Hi there, I work on protobufs. I noticed your project is using APIs from
google/protobuf/util/internal
:https://github.com/grpc-ecosystem/grpc-httpjson-transcoding/blob/master/src/json_request_translator.cc#L23-L24
These APIs have "internal" in the include path, and are not for end-user consumption. We will likely be removing these soon, or at least changing their namespace to make it even clearer that these APIs are not for users.
This came to my attention because of this PR in our repo:
protocolbuffers/protobuf#5939 (comment)
The text was updated successfully, but these errors were encountered: