Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors on valid timestamps #4973

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Errors on valid timestamps #4973

merged 2 commits into from
Nov 22, 2024

Conversation

jakec-github
Copy link
Contributor

References to other Issues or PRs

Fixes #4967

Have you read the Contributing Guidelines? Yes

Brief description of what is fixed or changed

Fixes acceptance of invalid timestamps as query parameters

Other comments

johanbrandhorst
johanbrandhorst requested changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, but lets use the error with extra context

runtime/query.go Show resolved Hide resolved
johanbrandhorst
johanbrandhorst approved these changes Nov 22, 2024
View reviewed changes
runtime/query.go Show resolved Hide resolved
@johanbrandhorst johanbrandhorst enabled auto-merge (squash) November 22, 2024 00:05
@johanbrandhorst johanbrandhorst merged commit 2a4bf6a into grpc-ecosystem:main Nov 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timestamps in year 0000 are accepted as query parameters
2 participants
@jakec-github @johanbrandhorst