Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default support for proto over http #465

Closed
MatthewDolan opened this issue Sep 27, 2017 · 3 comments
Closed

Add default support for proto over http #465

MatthewDolan opened this issue Sep 27, 2017 · 3 comments
Labels
waiting on reporter

Comments

@MatthewDolan
Copy link
Contributor

Add support for serialized protos to be sent to the http endpoints in addition to json. Use a different content type to differentiate between them.

This requires adding a new marshaller for []byte -> proto.

PR here: #459
@achew22
Copy link
Collaborator

achew22 commented Nov 16, 2017

If you want to resurrect that PR, I think I'd be happy to merge it

@MatthewDolan
Copy link
Contributor Author

Re-opened. Thanks.

@achew22 achew22 closed this as completed Nov 16, 2017
@achew22
Copy link
Collaborator

achew22 commented Nov 16, 2017

Merged it. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waiting on reporter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@achew22 @MatthewDolan