Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

returned errors should conform to google.rpc.Status #399

Closed
tmc opened this issue May 26, 2017 · 4 comments
Closed

returned errors should conform to google.rpc.Status #399

tmc opened this issue May 26, 2017 · 4 comments

Comments

@tmc
Copy link
Collaborator

tmc commented May 26, 2017

refs https://cloud.google.com/apis/design/errors
@tamalsaha
Copy link
Collaborator

If you use the grpc-go/status package, you are automatically following this proto. https://github.com/grpc/grpc-go/blob/master/status/status.go#L49

Is any further change needed?

@kazegusuri
Copy link
Contributor

Yes, status proto as error was introduced via #378.

@tmc
Copy link
Collaborator Author

tmc commented May 28, 2017

I'm referring to the fields that are encoded on the errorBody type

@tmc
Copy link
Collaborator Author

tmc commented May 30, 2017

This is addressed by #378, my mistake.

@tmc tmc closed this as completed May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tmc @tamalsaha @kazegusuri