Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protoc-gen-grpc-gateway doesn't work correctly with option go_package #207

Closed
favadi opened this issue Aug 4, 2016 · 4 comments
Closed

Comments

@favadi
Copy link
Contributor

favadi commented Aug 4, 2016

Those below options are valid and generated correctly with grpc-gen-go, but doesn't work with grpc-gateway.

  • option go_package = "github.com/9bug/bug;pb";
  • option go_package = "github.com/9bug/bug-1";

The error message is:

E0803 14:31:41.864791   20176 generator.go:74] 11:13: expected declaration, found 'IDENT' pb: 

I created a repo to reproduce this problem, and the build result.

@favadi
Copy link
Contributor Author

favadi commented Dec 7, 2016

I'm trying to support this alias feature myself.

@favadi
Copy link
Contributor Author

favadi commented Dec 8, 2016

I submit #277 to fix the failure in first case. It passes all the tests.

@favadi
Copy link
Contributor Author

favadi commented Dec 8, 2016

I also pushed fix for latter case to above PR.

@favadi
Copy link
Contributor Author

favadi commented Dec 8, 2016

Closing this as there is a PR to track it already.

@favadi favadi closed this as completed Dec 8, 2016
@tamalsaha tamalsaha mentioned this issue Mar 30, 2017
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant