Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Support for non-nullable nested messages. #20

Closed
dmitshur opened this issue Jun 18, 2015 · 1 comment
Closed

Feature Request: Support for non-nullable nested messages. #20

dmitshur opened this issue Jun 18, 2015 · 1 comment

Comments

@dmitshur
Copy link
Contributor

gogo protobuf generator has an option to generate non-nullable nested messages via an [(gogoproto.nullable) = false] option.

Could support for that be added to grpc-gateway in its populateQueryParameter func?

Since the code change is really small, I will make a PR that resolves this issue, but of course this it will need discussion/review.
@dmitshur dmitshur mentioned this issue Jun 18, 2015
Merged
@dmitshur
Copy link
Contributor Author

I've opened #21 that resolves this issue, please take a look and review.

@yugui yugui closed this as completed in #21 Jun 19, 2015
ithinker1991 referenced this issue in tronprotocol/grpc-gateway Apr 26, 2018
@ybhgenius
Merge pull request #20 from ybhgenius/master
c9d41ff 
Protocol document update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dmitshur