Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with tableview #12

Open
Bensge opened this issue Jan 14, 2012 · 4 comments
Open

Issue with tableview #12

Bensge opened this issue Jan 14, 2012 · 4 comments

Comments

@Bensge
Copy link

Bensge commented Jan 14, 2012

I tried to add this to my tableview.
I can see the arrow on top of the tableview, but the arrow isn't rotating or anything. I think it isn't recognizing my tableview as a scrollview. How can i fix that?

@gmckenzi
Copy link

Same issue here.
Not that it should matter, but I'm in a storyboard-based project.
I'm going to try and debug what is going on.

@gmckenzi
Copy link

Problem is that commit a45158 accidentally dropped this line from near the end of initWithScrollView:

    [self setState:kPullToRefreshViewStateNormal];

See my modified PullToRefreshView.m in this gist here:

https://gist.github.com/1611706

@gmckenzi
Copy link

Another issue...the statusLabel doesn't appear anymore as the statusLabel initializer was changed in commit 3238b01.
Prior to that commit the statusLabel initializer was:

statusLabel = [[UILabel alloc] initWithFrame:CGRectMake(0.0f, frame.size.height - 48.0f, self.frame.size.width, 20.0f)];

I've updated the gist ( https://gist.github.com/1611706 )

@ryanwersal
Copy link

@gmckenzi Since you actually found the issues, are you interested in doing a fork and pull request to get this project updated? I have added the changes you mentioned to my own fork, but I want credit to go to you since you did the actual hard work. If you just want me to issue the pull request, I can.

Or I guess hopefully chpwn can get it updated as well based off your gist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants