Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename of static accessor method fails to rename property-style access w/o object expression #682

Open
eric-milles opened this issue Aug 18, 2018 · 0 comments
Labels

Comments

@eric-milles
Copy link
Member

eric-milles commented Aug 18, 2018

Consider the following:

package a
class B {
  static def getX() {}
}
import static a.B.getX
x

x is a static method call expression for getX. Renaming getX in B properly renames the static import reference, but fails to rename the static method call expression.

Note: This happens because the static import is renamed in the first phase of the rename refactoring. Then the rename participant is called to find property-style accesses. At that time, type inferencing cannot establish the connection between the expression x and the static import, which now refers to the new name for the accessor.

See #678 for more details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant