Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroovyEditor.updateOccurenceAnnotation blocks Eclipse UI thread for no reason #250

Closed
frozenspider opened this issue Dec 27, 2016 · 4 comments

Comments

@frozenspider
Copy link

I'm using Eclipse (GGTS) to work with a rather big Grails project, and from time to time it just hangs for no apparent reason for a several minutes (!). This makes Eclipse almost unbearable to use.
Last time I got enough of it, so I used Java VisualVM to investigate what's happening.

As it turned out, the culprit is GroovyEditor.updateOccurenceAnnotation which executes in main thread, rendering Eclipse completely unresponsive and unusable randomly for few minutes straight.

My environment details:

  • Windows 8.1
  • jdk1.7.0_45 x64
  • GGTS 3.6.4.RELEASE with Groovy-Eclipse Feature 2.9.2.xx-201502281941-e44

Stuff captured with VisualVM:

@eric-milles
Copy link
Member

@frozenspider Could you try to recreate with the latest Groovy-Eclipse snapshot? There have been a lot of changes recently. The update annotation method suggests this may be somehow related to #155.

@eric-milles
Copy link
Member

I'm having a look at the code in question. If you want to work around this problem without an update, you can toggle off the Mark Occurrences item in the toolbar (Alt-Shift-O).

@eric-milles
Copy link
Member

Can you try again with the latest snapshot release? There is nothing running in the UI thread that the Java editor does not do for the same purpose. That being said, it does parse and partially compile the source in order to located occurrences. This can take a couple seconds in some cases. The GroovyOccurrencesFinder uses the CodeSelectHelper to find occurrences and the helper has been fixed up a lot recently.

@frozenspider
Copy link
Author

Sorry for the delay, I've just returned from my vacation. Thanks, I'll try it and let you know how it performs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants