Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch - Code Parity Review #4603

Open
SeamusLeonardHPE opened this issue Dec 16, 2024 · 2 comments
Open

Switch - Code Parity Review #4603

SeamusLeonardHPE opened this issue Dec 16, 2024 · 2 comments
Assignees
Labels
Phase:Current Sprint Used for issues that are being worked on current sprint.

Comments

@SeamusLeonardHPE
Copy link
Collaborator

Switch has been created as a separate component form Checkbox to aid with discoverability and prevent misconfiguration.

Review to see if props align with Grommet

https://www.figma.com/design/5NUO23O2mDjiulO2H0S2Os/v2-Construction-Site?node-id=5012-161185&t=P9ZIdBb6Hf53Whzq-4

@SeamusLeonardHPE SeamusLeonardHPE added the Phase:Current Sprint Used for issues that are being worked on current sprint. label Dec 17, 2024
@britt6612
Copy link
Collaborator

@SeamusLeonardHPE

Again the error color does not look correct.
Screenshot 2024-12-18 at 7 39 38 PM

Is there a way to edit the label I did not see this while reviewing?

@SeamusLeonardHPE
Copy link
Collaborator Author

@britt6612 not sure why the error color is mis behaving on the dev playground, but its correct on the canvas.

We removed the text prop in these input in formfield components to reduce complesity in the prop panel.
Will review in the new year is it has a negative impact on code-connect, or comprehension for dev handoff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Phase:Current Sprint Used for issues that are being worked on current sprint.
Projects
None yet
Development

No branches or pull requests

2 participants