Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormField - Missing info icon within Label #4576

Open
1 of 3 tasks
KennyAtHPE opened this issue Dec 13, 2024 · 4 comments
Open
1 of 3 tasks

FormField - Missing info icon within Label #4576

KennyAtHPE opened this issue Dec 13, 2024 · 4 comments

Comments

@KennyAtHPE
Copy link
Collaborator

KennyAtHPE commented Dec 13, 2024

Affected Components

DSCC

  • Form / Label / Default-with icon
  • Form / Label / Required-with icon

Design System

  • .formField- REVIEW

Missing use case

Image

Image
Opens a popover on press.

  • Review Figma component/variant
  • Decide with team whether or not this variant should be ignored, built within the DS v2 component, or created as a private asset owned by DSCC
  • Update based on decision

Resources

DSCC "Form / Label / Default-with icon" + "Form / Label / Required-with icon"

@KennyAtHPE
Copy link
Collaborator Author

@KennyAtHPE
Copy link
Collaborator Author

KennyAtHPE commented Dec 18, 2024

12/18 Update:
More use cases

Questions for Judy:

  • When is this used over the info message?
    - Trying to limit the usage of the popover icon.
    - Struggles to know when to show the info on the page.
    - Popover icon is used to save space even though this may not be the best solution
    - Help text/info message is used for shorter messages. Sometimes, a popover icon is needed since the additional info is long
    - DSCC doesn't like the usage of the popover icon
  • Are they accessible?
    - If it is additional information then they aren't worried that keyboard users aren't able to access it
    - Have to double-check with devs whether or not it can be accessed. Does it have a focus?

@KennyAtHPE
Copy link
Collaborator Author

Examples of popovers being used alongside labels of a FormField:

@KennyAtHPE
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant