Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display of Select All button on search in the SelectMultiple component when limit is provided #7219

Open
AkritMalla opened this issue May 1, 2024 · 0 comments · May be fixed by #7245
Open
Assignees
Labels
bug issue that does not match design or documentation and requires code changes to address

Comments

@AkritMalla
Copy link

AkritMalla commented May 1, 2024

Description

In the SelectMultiple component where limit property is provided, don't select any option. Then, in the search bar, search something. The Select All button does not get displayed.
Select any option from the dropdown and then search again with a keyword that does not match the selected value but matches other values in the list. Then the Select All button gets displayed.

Expected Behavior

In the SelectMultiple component where limit property is provided, on search the Select All button should not get displayed no matter when.

Actual Behavior

In the SelectMultiple component where limit property is provided, on search the Select All button is getting displayed when selecting one or more option.

URL, Media describing the Issue

Issue in SelectMultiple in Grommet:
https://hpe-my.sharepoint.com/:v:/r/personal/akrit_malla_hpe_com/Documents/Microsoft%20Teams%20Chat%20Files/SelectMultiple%20-%20Grommet%20-%20Google%20Chrome%202024-04-30%2016-26-20.mp4?csf=1&web=1&e=2mothY&nav=eyJyZWZlcnJhbEluZm8iOnsicmVmZXJyYWxBcHAiOiJTdHJlYW1XZWJBcHAiLCJyZWZlcnJhbFZpZXciOiJTaGFyZURpYWxvZy1MaW5rIiwicmVmZXJyYWxBcHBQbGF0Zm9ybSI6IldlYiIsInJlZmVycmFsTW9kZSI6InZpZXcifX0%3D

Issue in SelectMultiple in HPE GLCP UI:
https://hpe-my.sharepoint.com/:v:/r/personal/akrit_malla_hpe_com/Documents/Microsoft%20Teams%20Chat%20Files/HPE%20GreenLake%20-%20Select%20All%20issue.mp4?csf=1&web=1&e=7qOCZ9&nav=eyJyZWZlcnJhbEluZm8iOnsicmVmZXJyYWxBcHAiOiJTdHJlYW1XZWJBcHAiLCJyZWZlcnJhbFZpZXciOiJTaGFyZURpYWxvZy1MaW5rIiwicmVmZXJyYWxBcHBQbGF0Zm9ybSI6IldlYiIsInJlZmVycmFsTW9kZSI6InZpZXcifX0%3D

image

Steps to Reproduce

In Grommet:

  • Create a SelectMultiple component where limit property is provided
  • Don't select anything. Search something that exists, the Select All does not get displayed.
  • Clear the search and select any option from dropdown.
  • Search with a keyword that does not match the selected value but matches other values in the list.
  • Select All option gets displayed.

In HPE GLCP UI:

  • Login to MSP workspace as Admin
  • Click Manage Workspace > Identity & Access > Users > Any User in the list > Assign Role button
  • Select a service manager and Role
  • In the option "What customer workspaces does the role assignment apply to?" select "Specific workspace groups"
  • Don't select anything. Search something that exists, the Select All does not get displayed.
  • Clear the search and select any option from dropdown.
  • Search with a keyword that does not match the selected value but matches other values in the list.
  • Select All option gets displayed.

Your Environment

  • Grommet version: 2.33.2
  • Browser Name and version: Google Chrome Version 124.0.6367.91
  • Operating System and version (desktop or mobile): Windows 11 Enterprise OS Version 22H2 (desktop)
@halocline halocline added the bug issue that does not match design or documentation and requires code changes to address label May 1, 2024
@britt6612 britt6612 self-assigned this May 29, 2024
@britt6612 britt6612 linked a pull request May 29, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug issue that does not match design or documentation and requires code changes to address
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants