Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting background on DataTable overrides hover/focus background styling #153

Open
kariwhitcomb opened this issue Jan 14, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@kariwhitcomb
Copy link

Expected Behavior

Default hover and focus behavior of DataTable should still be applied when background prop is set

Actual Behavior

Unless the background value is semi-transparent, the hover/focus styling is lost.

URL, screen shot, or Codepen exhibiting the issue

https://codesandbox.io/s/zealous-sun-o6jni?file=/src/App.js

Steps to Reproduce

Tested using the HPE theme
<DataTable ... background={['background', 'background-contrast']} onClickRow={() => {}} />

Hover over a table row. The ones with background-contrast show a hover effect, but the background rows do not.
Same if you tab to table and then use up/down to navigate rows.

Removing the background prop reenables hover/focus styling

Your Environment

  • Grommet version: 2.16.2 (HPE theme 2.0.2)
  • Browser Name and version: Chrome latest
  • Operating System and version (desktop or mobile): MacOS
@ShimiSun ShimiSun transferred this issue from grommet/grommet Jan 15, 2021
@ShimiSun
Copy link
Collaborator

I've transferred the issue to the HPE theme repo, since grommet itself doesn't have a background color, and the color is coming from the theme. Thank you for filing the issue.

@ShimiSun ShimiSun added the bug Something isn't working label Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants