From b1933ef2f62947cbea1298ab49a2dae0d7e496a4 Mon Sep 17 00:00:00 2001 From: Taylor Seamans Date: Thu, 8 Sep 2022 14:56:59 -0700 Subject: [PATCH 1/2] Update default severity to warn --- lib/index.js | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/index.js b/lib/index.js index 66b386d..f323277 100644 --- a/lib/index.js +++ b/lib/index.js @@ -22,14 +22,14 @@ module.exports.configs = { plugins: ['grommet'], rules: { 'grommet/anchor-label': 'warn', - 'grommet/button-single-kind': 'error', - 'grommet/datatable-aria-describedby': 'error', - 'grommet/datatable-groupby-onmore': 'error', - 'grommet/formfield-htmlfor-id': 'error', - 'grommet/formfield-name': 'error', - 'grommet/formfield-prefer-children': 'error', - 'grommet/image-alt-text': 'error', - 'grommet/spinner-message': 'error', + 'grommet/button-single-kind': 'warn', + 'grommet/datatable-aria-describedby': 'warn', + 'grommet/datatable-groupby-onmore': 'warn', + 'grommet/formfield-htmlfor-id': 'warn', + 'grommet/formfield-name': 'warn', + 'grommet/formfield-prefer-children': 'warn', + 'grommet/image-alt-text': 'warn', + 'grommet/spinner-message': 'warn', }, }, }; From 95074a08412945b2099ea321c851f58049c56863 Mon Sep 17 00:00:00 2001 From: Taylor Seamans Date: Fri, 9 Sep 2022 15:37:53 -0500 Subject: [PATCH 2/2] Update default type --- lib/rules/anchor-label.js | 1 + lib/rules/button-icon-a11ytitle.js | 1 + lib/rules/button-single-kind.js | 2 +- lib/rules/formfield-htmlfor-id.js | 1 + lib/rules/formfield-name.js | 1 + lib/rules/formfield-prefer-children.js | 2 +- 6 files changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/rules/anchor-label.js b/lib/rules/anchor-label.js index b09775d..ed0506c 100644 --- a/lib/rules/anchor-label.js +++ b/lib/rules/anchor-label.js @@ -10,6 +10,7 @@ module.exports = { meta: { + type: 'problem', docs: { description: 'Rule to enforce descriptive anchor label', category: 'Best Practices', diff --git a/lib/rules/button-icon-a11ytitle.js b/lib/rules/button-icon-a11ytitle.js index 4c952c7..fa82e27 100644 --- a/lib/rules/button-icon-a11ytitle.js +++ b/lib/rules/button-icon-a11ytitle.js @@ -10,6 +10,7 @@ module.exports = { meta: { + type: 'problem', docs: { description: 'Rule to enforce a11yTitle on icon-only buttons', category: 'Best Practices', diff --git a/lib/rules/button-single-kind.js b/lib/rules/button-single-kind.js index 760eb02..d43dc58 100644 --- a/lib/rules/button-single-kind.js +++ b/lib/rules/button-single-kind.js @@ -10,7 +10,7 @@ module.exports = { meta: { - type: 'problem', + type: 'suggestion', docs: { description: 'Rule to ensure Button does not have multiple kinds applied', category: 'Best Practices', diff --git a/lib/rules/formfield-htmlfor-id.js b/lib/rules/formfield-htmlfor-id.js index f02a581..0ac36e1 100644 --- a/lib/rules/formfield-htmlfor-id.js +++ b/lib/rules/formfield-htmlfor-id.js @@ -10,6 +10,7 @@ module.exports = { meta: { + type: 'problem', docs: { description: 'Rule to enforce matching htmlFor and id on FormField and its child input, respectively', diff --git a/lib/rules/formfield-name.js b/lib/rules/formfield-name.js index dbf53fe..0942dcb 100644 --- a/lib/rules/formfield-name.js +++ b/lib/rules/formfield-name.js @@ -10,6 +10,7 @@ module.exports = { meta: { + type: 'problem', docs: { description: 'Rule to enforce name on FormField and its child input', category: 'Best Practices', diff --git a/lib/rules/formfield-prefer-children.js b/lib/rules/formfield-prefer-children.js index 3db7947..e382880 100644 --- a/lib/rules/formfield-prefer-children.js +++ b/lib/rules/formfield-prefer-children.js @@ -10,6 +10,7 @@ module.exports = { meta: { + type: 'suggestion', docs: { description: 'Recommend use of children with FormField as opposed to component property', @@ -22,7 +23,6 @@ module.exports = { 'formfield-prefer-children': `It is not recommended to use the 'component' property. Instead, implement the input as a child of FormField.`, }, - type: 'suggestion', }, create: function (context) {