Added base64, image.png, wasm data: to image, (limited) support for namespaces (virtual map access). moved the image functions under image.* #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mage function under image.*
ccoVeille
reviewed
Sep 6, 2024
ccoVeille
approved these changes
Sep 6, 2024
…for image producing
ldemailly
changed the title
ccoVeille
reviewed
Sep 6, 2024
Comment on lines
+31
to
+35
| for _, b := range []byte(name) { | ||
| if !lexer.IsAlphaNum(b) { | ||
| return false | ||
| } | ||
| } |
There was a problem hiding this comment.
Usually it's better to loop on runes from a string
Unicode characters such as accent, and emoji are badly checked otherwise
Then Unicode package can be used to check the type
There was a problem hiding this comment.
it's on purpose (for now at least) only bytes (ascii) is allowed outside of strings
unicode does work fine inside strings (as demoed in many examples)
ldemailly
commented
Sep 7, 2024
| @@ -380,6 +380,7 @@ func EvalOne(ctx context.Context, s *eval.State, what string, out io.Writer, opt | |||
| }() | |||
| } | |||
| s.SetContext(ctx, options.MaxDuration) | |||
| defer s.Cancel() | |||
There was a problem hiding this comment.
This is the fix for the wasm errors! (#204 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #212
Fixes #204