Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected initial state mutation #49

Closed
futpib opened this issue Oct 16, 2018 · 1 comment
Closed

Unexpected initial state mutation #49

futpib opened this issue Oct 16, 2018 · 1 comment

Comments

@futpib
Copy link

futpib commented Oct 16, 2018 •
edited
Loading

The getStateFromCookies(initialState, paths) call will mutate initialState.

In server-side rendering setting this leads to really bad stuff like different users getting other user's cookies in their state.

Had to do getStateFromCookies(clone(initialState), paths) to avoid this.
@ashbhir ashbhir mentioned this issue Mar 25, 2019
Merged
@ashbhir
Copy link
Contributor

ashbhir commented Mar 25, 2019

Issues fixed by PR #51. Hence closing the issue.

@ashbhir ashbhir closed this as completed Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@futpib @ashbhir