Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated imp module with importlib #108

Closed
hugovk opened this issue Apr 28, 2023 · 2 comments
Closed

Replace deprecated imp module with importlib #108

hugovk opened this issue Apr 28, 2023 · 2 comments

Comments

@hugovk
Copy link

hugovk commented Apr 28, 2023

This library uses the imp module which has been deprecated since Python 3.4 and set for removal in 3.12:

Python 3.12 is set for release on 2023-10-02 and this library is one of the top 5,000 most-downloaded from PyPI.

Please could you upgrade to use importlib? The imp docs have suggestions on what to use to replace each function and constant.

@dsagal
Copy link
Member

dsagal commented Apr 29, 2023

Actually, asttokens does not use the imp module. It is present in one of test fixtures that tests read for testing some parsing logic. Anything in the tests/testdata directory is only parsed by tests but not executed, and it shouldn't make a difference whether an import mentioned in that directory is deprecated or if it's even exists.

@hugovk
Copy link
Author

hugovk commented Apr 29, 2023

Good to hear, thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants