-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prompt Drivers Crash When Streaming Without A Structure #643
Comments
@collindutter Can I do it? |
@torabshaikh sure! Thanks :) |
Hey @torabshaikh, just checking in to see if you had any questions on this! Let us know if there's anything we can do to help. |
@collindutter I have started working on it. I will surely ask you if I have any doubts. |
Hi @collindutter , I have replaced |
@torabshaikh can you make it so the Prompt Driver takes |
Hi @collindutter I just submitted #914 for this. Please review. |
Describe the bug
Prompt Drivers require
structure
to be set in order to publishCompletionChunkEvents
.To Reproduce
Steps to reproduce the behavior:
Expected behavior
Prompt Drivers should not depend on a Structure just to stream. Perhaps they should take in an
event_listener: EventListener
instead of astructure: Structure
. If a Structure is the one using the Prompt Driver, it can provide anEventListener
. Otherwise we can default one.Screenshots
N/A
Desktop (please complete the following information):
N/A
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: