Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for GCC 14 #1121

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Fix for GCC 14 #1121

merged 2 commits into from
Oct 28, 2024

Conversation

foxtran
Copy link
Contributor

@foxtran foxtran commented Oct 28, 2024

This patch removes uninitialised but used stmp that leads to bugs with novel GCC's. All cmake tests for xtb were passed.

Fixes #1109

foxtran and others added 2 commits October 28, 2024 15:12
@foxtran
Remove unused stmp
cef2c2b 
Signed-off-by: Igor S. Gerasimov <[email protected]>
@foxtran
All versions of GCC are able to compile xTB
4a22843 
Signed-off-by: Igor S. Gerasimov <[email protected]>
awvwgk
awvwgk approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for sharing.

@awvwgk awvwgk merged commit e39b5ca into grimme-lab:main Oct 28, 2024
13 checks passed
@foxtran foxtran mentioned this pull request Oct 28, 2024
Open
@foxtran foxtran deleted the patch-1 branch October 29, 2024 07:42
@toxtran toxtran mentioned this pull request Nov 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awvwgk awvwgk awvwgk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xTB + GCC 14.1: multiple test fails
2 participants
@foxtran @awvwgk