Inconsistent definition of copy! for PETScVector ?

[fverdugo]

I have the feeling that the definition of these two functions:

GridapPETSc.jl/src/PETScArrays.jl

Line 121 in 3ba0de4

function Base.copy!(vec::AbstractVector,petscvec::PETScVector)

GridapPETSc.jl/src/PETScArrays.jl

Line 136 in 3ba0de4

function Base.copy!(petscvec::PETScVector,vec::AbstractVector)

is inconsistent with the Julia definition of copy!:

help?> copy!
search: copy! copyto! circcopy! unsafe_copyto! copy copysign deepcopy

  copy!(dst, src) -> dst

  In-place copy of src into dst, discarding any pre-existing elements in dst.
  If dst and src are of the same type, dst == src should hold after the call.
  If dst and src are multidimensional arrays, they must have equal axes. See
  also copyto!.

In particular, with the sentence "if dst and src are multidimensional arrays, they must have equal axes. " As far as I can tell this means that length(dst) == length(src) should be true. And I think that this is not true in the functions linked above. In other words, both vectors need to be understood either as global vectors, or as local ones.

@amartinhuertas Do you remember why you needed to change these functions?

[amartinhuertas]

@amartinhuertas Do you remember why you needed to change these functions?

I did not change them, I added them. They are new. I added them along with their two counterparts in PartitionedArrays.jl for the PVector,PETScVector combinations, and vice-versa.

These are needed in order to copy from PETSc vectors to the vectors that were used to assemble the system, either PVector or plain Julia Vectors.

Does all this answer your question?

[amartinhuertas]

Solved in PR #53