MultiValues component names export #1038
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation for parallel vtk missing
Moved components naming into MultiValue's API and set a default
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1038 +/- ##
==========================================
+ Coverage 88.40% 88.42% +0.01%
==========================================
Files 180 180
Lines 23239 23273 +34
==========================================
+ Hits 20545 20578 +33
- Misses 2694 2695 +1 ☔ View full report in Codecov by Sentry. |
JordiManyer
reviewed
Oct 21, 2024
src/Visualization/Vtk.jl
Outdated
| @@ -94,10 +94,12 @@ function create_vtk_file( | |||
|
|
|||
| if num_cells(trian)>0 | |||
| for (k,v) in celldata | |||
| vtk_cell_data(vtkfile, _prepare_data(v), k) | |||
| comp_names = _data_component_names(v) | |||
There was a problem hiding this comment.
I would replace this by
component_names = _data_component_names(v)
vtk_cell_data(vtkfile, _prepare_data(v), k; component_names)and idem everywhere else.
There was a problem hiding this comment.
Oh I didn't know this trick, I changed these.
There was a problem hiding this comment.
Actually the setindex overload is so cursed that I cannot avoid repeating the kwarg name in it :') .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1036.