-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could not run example model in JOSS paper #299
Comments
I'm receiving the same error just by trying the example model under the "get started" section. I'm running R version 3.6.1 on Windows 10 |
Thanks @lionel68. I think this is due to you using a recent version of TF/TFP, but the CRAN (rather than dev) version of greta (0.3.0). If you install the most recent version of greta (0.3.0.9008), from GitHub I think it should work: remotes::install_github("greta-dev/greta") Up until now, I've been specifying minimum versions of TF and TFP as dependencies (ie. TF >= 1.10; TFP >=0.3.0). I think that's generally considered better practice than depending on specific versions. But the APIs for both of these packages (but particularly TFP) change so frequently, that errors keep occurring, making it impossible to maintain. So the development (GitHub) version of greta now depends on specific releases (TF = 1.14, TFP = 0.7.0), which is what I'm planning to do in the future. I can see why you went for the CRAN version, and the JOSS review is for greta 0.3.0, but I'm not clear on how that works with dev versions. I'll ask the editor's opinion over on that channel. |
Yes, that did the job I can now smoothly run greta, thanks! |
I tried to run the example model in the JOSS paper in my R session but got the following error:
Here is my sessionInfo():
And the code I used:
The text was updated successfully, but these errors were encountered: