Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing of custom fonts #285

Merged
merged 2 commits into from
Oct 30, 2020
Merged

Allow passing of custom fonts #285

merged 2 commits into from
Oct 30, 2020

Conversation

MatthewHerbst
Copy link
Owner

Fixes #281

@MatthewHerbst MatthewHerbst mentioned this pull request Sep 7, 2020
Closed
@KiltedDrummer
Copy link

This looks like a good solution to the issue in #281
Other than the conflict in the README that needs to be resolved.
Would love to see this get resolved, merged, and released since I am also hitting this issue

@MatthewHerbst
Copy link
Owner Author

Hi @KiltedDrummer have you been able to verify that this fixes the problem for you? I'm confident this doesn't break anything but I want to make sure it actually solves the problem 😄

@KiltedDrummer
Copy link

@MatthewHerbst Confirmed it on local.
I pulled down this branch, linked it, added font data, and no issues with printing.

@MatthewHerbst MatthewHerbst merged commit b28504b into master Oct 30, 2020
@MatthewHerbst MatthewHerbst deleted the fonts branch October 30, 2020 21:56
@MatthewHerbst
Copy link
Owner Author

Published as v2.11.0 🎉

@k-jiang k-jiang mentioned this pull request Nov 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KiltedDrummer KiltedDrummer KiltedDrummer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom fonts not copying correctly
2 participants
@MatthewHerbst @KiltedDrummer