Create method onBeforeGetContent

[andfs]

Sometimes is useful to update the component to print before printing, for example, when someone needs to hide somethings in the printing.
The component triggers the method getContent an then calls onBeforePrinting, but at this time, the component is mounted and everything that you do in onBeforePrinting is not reflected in the component.
So with onBeforeGetContent is possible to update the component before printing

[MatthewHerbst]

Hi, thanks for the PR. A couple questions about the code. I like the idea, though we need to flesh it out a bit with how it would work.

Can you please update the docs as part of the PR, and, please provide an example of how this would work?

[MatthewHerbst]

Also, we do not use Yarn for this package, so please remove the yarn.lock file

[andfs]

Hi, thanks for the PR. A couple questions about the code. I like the idea, though we need to flesh it out a bit with how it would work.

Can you please update the docs as part of the PR, and, please provide an example of how this would work?

Hi @MatthewHerbst . I'll do that :)

[MatthewHerbst]

Please don't change the formatting of the entire file. Besides the fact that we have lint rules which will break, it makes the diff impossible to read

[MatthewHerbst]

We're really close here, thanks for making all the changes, just a few small ones left.

[MatthewHerbst]

Can you undo the formatting changes of the whole file please? Looking forward to getting this merged this week :)

[MatthewHerbst]

Looks great! Can you please just squash your commits now into a single commit and then I'll merge?

[MatthewHerbst]

🎉 awesome, thank you! Will merge now. I'm going to make another commit cleaning up a few things across the library. Hope to have a release with this included in it tonight or tomorrow!

[MatthewHerbst]

Oh wait, one thing, please squash the commits first! Do you know how to do that?

[andfs]

Oh wait, one thing, please squash the commits first! Do you know how to do that?

I think I squashed in my last push, didn't I?

[MatthewHerbst]

Oh wait, one thing, please squash the commits first! Do you know how to do that?

I think I squashed in my last push, didn't I?

Nope - there should only be a single commit after you squash, right now there are 13 commits.

[andfs]

Oh wait, one thing, please squash the commits first! Do you know how to do that?

I think I squashed in my last push, didn't I?

Nope - there should only be a single commit after you squash, right now there are 13 commits.

Sorry. I think I did it right.

I thought that was that:
74d61df

Could you tell me how to do it?

[MatthewHerbst]

Let me know if you have any trouble from this: https://github.com/wprig/wprig/wiki/How-to-squash-commits

[andfs]

Let me know if you have any trouble from this: https://github.com/wprig/wprig/wiki/How-to-squash-commits

sorry, but I wasn't able to make it work :/

[andfs]

Let me know if you have any trouble from this: https://github.com/wprig/wprig/wiki/How-to-squash-commits

There is another way to squash it?

[MatthewHerbst]

Can you add me to have permissions to push to your fork of react-to-print? I can fix the branch for you

[andfs]

Can you add me to have permissions to push to your fork of react-to-print? I can fix the branch for you

sure

[MatthewHerbst]

I'm trying to push it up to your branch but it's not letting me. I can keep trying, or I can push it as a new PR and change the author on the commit to you. Would that be ok with you?

[andfs]

I'm trying to push it up to your branch but it's not letting me. I can keep trying, or I can push it as a new PR and change the author on the commit to you. Would that be ok with you?

of course, no problem :)

[MatthewHerbst]

Squashed and ready to go in #160

[MatthewHerbst]

Published as v2.4.0. Thanks so much for your work on this!