-
-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed import bug #116
Fixed import bug #116
Conversation
Thanks for the PR! Can you explain why this fixes it please? Changes make sense, just not sure what the issue with the current setup is |
@MatthewHerbst Hi, unfortunately I am not sure either why the previous setup didn't work but it looked like an issue with the entry point. I stumbled upon the issue after having the exact same error on my project. I checked this new setup on a project I am working on and it looks o.k. |
I can confirmed that this PR works. And i think is because UMD (Universal Module Definition) is well... more "universal" and compatible with both AMD and CommonJS |
Was the previous build (before 2.1) UMD? @sergeyshmakov did the TS PR change the build type? |
Ah yes. The TS conversion added |
Soon as I land from vacation Saturday. Sorry for the delay |
@MatthewHerbst I'm still swamped from traveling. I've added you to have publishing access on npm. Can you test let me know if you have any issues? |
v2.1.1 is published. Please report any problems. Thank you everyone for the help fixing this! (Thanks for the privileges @gregnb!) |
Awesome! No problem thanks for all your help :) |
Fix for #115.