Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useRef in example can be Typesafe - solves your TODO #311

Closed
nealeu opened this issue Nov 8, 2020 · 2 comments
Closed

useRef in example can be Typesafe - solves your TODO #311

nealeu opened this issue Nov 8, 2020 · 2 comments
Labels
enhancement TypeScript

Comments

@nealeu
Copy link

nealeu commented Nov 8, 2020

This line:
https://github.com/gregnb/react-to-print/blob/d6349a0c27e85887eddfe8b0f0e2832600b48869/example/FunctionalComponentWithHook/index.tsx#L9-L10

Can be:
const onBeforeGetContentResolve = useRef<(() => void) | null>(null);
@MatthewHerbst
Copy link
Owner

🥂 Thank you! Would you like to may the PR for that?

@MatthewHerbst
Copy link
Owner

Done in #320, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement TypeScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nealeu @MatthewHerbst