Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Link class. #42

Open
gregmuellegger opened this issue May 30, 2014 · 2 comments
Open

Refactor Link class. #42

gregmuellegger opened this issue May 30, 2014 · 2 comments

Comments

@gregmuellegger
Copy link
Owner

The Link class in base.py is an arcane relict from four years ago and hard to understand.

We should try to remove the class in incorporate the logic into the Autofixture class.

@AndreiPashkin
Copy link
Contributor

Do you have any ideas bout how it should be refactored?

@gregmuellegger
Copy link
Owner Author

Hm, let's see. The Link class is only used in the AutoFixtureBase class. So the functionality could be provided by methods of this class.

We would need to figure out which methods of Link are currently used in which places of AutoFixtureBase and replace those. These include things like if field.name in self.generate_fk (Line 269 in base.py, where self.generate_fk is an instance of Link

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants