From 4b791da42509aaf2f31bb2117ecc4ec7fca89a59 Mon Sep 17 00:00:00 2001 From: Greg Magolan Date: Tue, 16 Jul 2019 01:46:56 -0400 Subject: [PATCH] fix: fix for node windows cross-compile Fixes issue #909: Toolchains support: Failed to build on Windows for Linux --- internal/node/node_repositories.bzl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/node/node_repositories.bzl b/internal/node/node_repositories.bzl index 9c22fd4c46..410b208968 100644 --- a/internal/node/node_repositories.bzl +++ b/internal/node/node_repositories.bzl @@ -197,7 +197,7 @@ def _prepare_node(repository_ctx): """ # TODO: Maybe we want to encode the OS as a specific attribute rather than do it based on naming? - is_windows = is_windows_os(repository_ctx) or "_windows_" in repository_ctx.attr.name + is_windows = "_windows_" in repository_ctx.attr.name if repository_ctx.attr.vendored_node: node_exec = "/".join([f for f in [ "../../..",