fix count display for collections with GROUP BY #897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1, experienced just now. |
|
Thanks for this fix. Please add specs to "paginated_collection_spec.rb". |
|
spec added, but I did not dive much into the test suite, I've created 3 objects in database, and I'm not sure if I should care about cleaning them up |
|
@comboy That's perfect thanks! |
pcreux
added a commit
that referenced
this pull request
Jan 19, 2012
---
When used with something with GROUP BY as collection, size method will not return number, but hash instead. So instead of having some "Displaying all 123 posts", we get "Displaying all {"bar"=> 34, "baz" => 54} posts". Using total_count in case of a single page same as it is used for many pages, fixes the problem.
|
Thanks for quick merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used with something with GROUP BY as collection, size method will not return number, but hash instead. So instead of having some "Displaying all 123 posts", we get "Displaying all {"bar"=> 34, "baz" => 54} posts". Using total_count in case of a single page same as it is used for many pages, fixes the problem.