-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I have added feature tests for no paginator and no download links on index page #865
Conversation
Add option for non-paginated index pages. Prevent 'select count(*) from <table_name>' from being called on non-paginated tables.
Add option for non-paginated index pages. Prevent 'select count(*) from <table_name>' from being called on non-paginated tables.
…ents every scope from running a count(*) on the table for every index page load.
I have added another feature to index to disable scope counts: Usage: index :scope_count => false do |
…e normal collection count methods.
…la member_action and collection_action on resources).
For the custom methods on register_page's. Here's the usage: ActiveAdmin.register_page "Flash Page" do page_action :flash_me, :method => :get do content do |
@BoboFraggins I merged this patch into master. I removed the pagination feature since @pcreux already implemented it (although slightly differently). I wrote some of the docs, but more is definitely needed. Thanks for the pull request! Some great additions to Active Admin |
Sorry for misreading your last message.
I have also added a feature to add :if clauses to sidebars and action_items.
Usage:
sidebar :media_items, :only => :show, :if => proc{ user.is_artist? } do
"testing"
end
I created relevant feature tests for all of the above.