Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I have added feature tests for no paginator and no download links on index page #865

Closed
wants to merge 12 commits into from

Conversation

BoboFraggins
Copy link

Sorry for misreading your last message.

I have also added a feature to add :if clauses to sidebars and action_items.

Usage:

sidebar :media_items, :only => :show, :if => proc{ user.is_artist? } do
"testing"
end

I created relevant feature tests for all of the above.

Peter Fry added 10 commits December 7, 2011 13:32
Add option for non-paginated index pages.
Prevent 'select count(*) from <table_name>' from being called on non-paginated tables.
Add option for non-paginated index pages.
Prevent 'select count(*) from <table_name>' from being called on non-paginated tables.
…ents every scope from running a count(*) on the table for every index page load.
@BoboFraggins
Copy link
Author

I have added another feature to index to disable scope counts:

Usage:

index :scope_count => false do
...
end

Peter Fry added 2 commits January 4, 2012 09:40
…la member_action and collection_action on resources).
@BoboFraggins
Copy link
Author

For the custom methods on register_page's. Here's the usage:


ActiveAdmin.register_page "Flash Page" do

page_action :flash_me, :method => :get do
flash[:notice] = 'Whee!'
redirect_to request.referrer
end

content do
panel 'Need a flash?' do
link_to 'Flash Me', admin_flash_page_flash_me_url
end
end
end

@ghost ghost assigned gregbell Feb 3, 2012
@gregbell
Copy link
Contributor

gregbell commented Feb 3, 2012

@BoboFraggins I merged this patch into master. I removed the pagination feature since @pcreux already implemented it (although slightly differently).

I wrote some of the docs, but more is definitely needed. Thanks for the pull request! Some great additions to Active Admin

@gregbell gregbell closed this Feb 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants