Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#592: "stack level too deep" error when using :logout_path named route #780

Closed
wants to merge 1 commit into from
Closed

#592: "stack level too deep" error when using :logout_path named route #780

wants to merge 1 commit into from

Conversation

george
Copy link
Contributor

@george george commented Nov 23, 2011

See Issue #592

rake test passes, but rake test:major_supported_rails --trace gives me:

in /Users/george/work/open_source_contributions/active_admin)
** Invoke test:major_supported_rails (first_time)
** Execute test:major_supported_rails

== Using Rails 3.0.10
Removing the current Gemfile.lock
rm Gemfile.lock
export RAILS=3.0.10 && ./script/use_rails 3.0.10
Bundler could not find compatible versions for gem "activesupport":
  In Gemfile:
    activeadmin (>= 0) ruby depends on
      activesupport (~> 3.1.0) ruby

    rails (= 3.0.10) ruby depends on
      activesupport (3.0.10)


rake aborted!

/Users/george/work/open_source_contributions/active_admin/Rakefile:9:in `cmd'
/Users/george/work/open_source_contributions/active_admin/tasks/test.rake:27:in `block (3 levels) in <top (required)>'
/Users/george/work/open_source_contributions/active_admin/tasks/test.rake:18:in `each'
/Users/george/work/open_source_contributions/active_admin/tasks/test.rake:18:in `block (2 levels) in <top (required)>'
/Users/george/.rvm/gems/ruby-1.9.2-p290@active_admin/gems/rake-0.8.7/lib/rake.rb:636:in `call'
/Users/george/.rvm/gems/ruby-1.9.2-p290@active_admin/gems/rake-0.8.7/lib/rake.rb:636:in `block in execute'
/Users/george/.rvm/gems/ruby-1.9.2-p290@active_admin/gems/rake-0.8.7/lib/rake.rb:631:in `each'
/Users/george/.rvm/gems/ruby-1.9.2-p290@active_admin/gems/rake-0.8.7/lib/rake.rb:631:in `execute'
/Users/george/.rvm/gems/ruby-1.9.2-p290@active_admin/gems/rake-0.8.7/lib/rake.rb:597:in `block in invoke_with_call_chain'
/Users/george/.rvm/rubies/ruby-1.9.2-p290/lib/ruby/1.9.1/monitor.rb:201:in `mon_synchronize'
/Users/george/.rvm/gems/ruby-1.9.2-p290@active_admin/gems/rake-0.8.7/lib/rake.rb:590:in `invoke_with_call_chain'
/Users/george/.rvm/gems/ruby-1.9.2-p290@active_admin/gems/rake-0.8.7/lib/rake.rb:583:in `invoke'
/Users/george/.rvm/gems/ruby-1.9.2-p290@active_admin/gems/rake-0.8.7/lib/rake.rb:2051:in `invoke_task'
/Users/george/.rvm/gems/ruby-1.9.2-p290@active_admin/gems/rake-0.8.7/lib/rake.rb:2029:in `block (2 levels) in top_level'
/Users/george/.rvm/gems/ruby-1.9.2-p290@active_admin/gems/rake-0.8.7/lib/rake.rb:2029:in `each'
/Users/george/.rvm/gems/ruby-1.9.2-p290@active_admin/gems/rake-0.8.7/lib/rake.rb:2029:in `block in top_level'
/Users/george/.rvm/gems/ruby-1.9.2-p290@active_admin/gems/rake-0.8.7/lib/rake.rb:2068:in `standard_exception_handling'
/Users/george/.rvm/gems/ruby-1.9.2-p290@active_admin/gems/rake-0.8.7/lib/rake.rb:2023:in `top_level'
/Users/george/.rvm/gems/ruby-1.9.2-p290@active_admin/gems/rake-0.8.7/lib/rake.rb:2001:in `block in run'
/Users/george/.rvm/gems/ruby-1.9.2-p290@active_admin/gems/rake-0.8.7/lib/rake.rb:2068:in `standard_exception_handling'
/Users/george/.rvm/gems/ruby-1.9.2-p290@active_admin/gems/rake-0.8.7/lib/rake.rb:1998:in `run'
/Users/george/.rvm/gems/ruby-1.9.2-p290@active_admin/gems/rake-0.8.7/bin/rake:31:in `<top (required)>'
./bin/rake:16:in `load'
./bin/rake:16:in `<main>'

Not sure what to do with that.

…nfig.logout_link_path = :logout_path` and related named path are used.
@samvincent
Copy link
Contributor

I definitely lost some time trying to figure this one out the other day. In the end, I just used a string rather than a symbol. Thanks for this.

@george
Copy link
Contributor Author

george commented Nov 23, 2011

For others who might find their way here I'll repeat my comment from issue #592:

The workaround (which doesn't require this patch) is to change:

config.logout_link_path = :logout_path

to:

config.logout_link_path = :logout_url

or:

config.logout_link_path = 'logout'

@gregbell
Copy link
Contributor

Hi George!

Thanks for this patch! I'll take a look into why the rake task isn't working for you. It all passed on my machine.

Merged into master 7dd809e

@gregbell gregbell closed this Nov 25, 2011
Aerlinger pushed a commit to Aerlinger/active_admin that referenced this pull request Jun 3, 2014
Same behaviour, save that all actions now support multiple HTTP verbs.

Removes outdated test from activeadmin#780
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants