Fix plural resource label for default :destroy batch action #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same that was with Index pages and was fixed in: #2135
|
We should really have tests for translation functionality... |
|
It is same function that was used in #2135 |
|
What I'd like to see is a set of tests that, given a specific language, would check the resulting HTML to ensure all the different parts of the AA UI are properly translated. So, integration tests for i18n. But that's out of the scope of this PR... Anyway, thanks for fixing this :] |
seanlinsley
added a commit
that referenced
this pull request
Jun 6, 2013
Fix plural resource label for default :destroy batch action
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same that was with Index pages and was fixed in:
#2135
P.S. + added some missing translations for plural forms