Include JS in layout with rails helper

[tank-bohr]

Use Rails helper to include javascript. Assets pipeline divides manifest into separate files if assets.debug is true

[seanlinsley]

Could you elaborate more on what this solves?

[tank-bohr]

Therу is a common rails interface to include assets in layout. This is javascript_include_tag
If you use this helper assets served as sepearate files in development environment and as one file in production (see rails guides)

For example:

In active_admin initializer:

config.register_javascript 'my_javascript'

my_javascript.js is a manifest file with require directives

//= require jquery.ui.widget.js
//= require jquery.iframe-transport.js
//= require jquery.fileupload.js
//= require blah-blah.js

I see one file in html in development instead of four. Inspite of config.assets.debug is true. My PS solves this issue. It's not critical but it's more predictable for rails developers

By the way, stylesheets are included with rails tag (https://github.com/gregbell/active_admin/blob/master/lib/active_admin/views/pages/base.rb#L27). It would be better to include js the same way for consistency

[seanlinsley]

That doesn't quite work as I expected. With this change, all of these script tags showed up in the HTML:

<script src="/assets/jquery.js?body=1" type="text/javascript"></script>
<script src="/assets/jquery-ui.js?body=1" type="text/javascript"></script>
<script src="/assets/jquery_ujs.js?body=1" type="text/javascript"></script>
<script src="/assets/active_admin/lib/namespace.js?body=1" type="text/javascript"></script>
<script src="/assets/active_admin/components/jquery.aa.checkbox-toggler.js?body=1" type="text/javascript"></script>
<script src="/assets/active_admin/components/jquery.aa.dropdown-menu.js?body=1" type="text/javascript"></script>
<script src="/assets/active_admin/components/jquery.aa.popover.js?body=1" type="text/javascript"></script>
<script src="/assets/active_admin/components/jquery.aa.table-checkbox-toggler.js?body=1" type="text/javascript"></script>
<script src="/assets/active_admin/pages/application.js?body=1" type="text/javascript"></script>
<script src="/assets/active_admin/pages/batch_actions.js?body=1" type="text/javascript"></script>
<script src="/assets/active_admin/application.js?body=1" type="text/javascript"></script>
<script src="/assets/active_admin/base.js?body=1" type="text/javascript"></script>
<script src="/assets/active_admin.js?body=1" type="text/javascript"></script>

Do you have any idea what ?body=1 does? Visiting them in the browser:

/assets/active_admin.js        # returns the compiled version
/assets/active_admin.js?body=1 # returns an empty file

[tank-bohr]

That doesn't quite work as I expected. With this change, all of these script tags showed up in the HTML

What do you expected? This is exactly what I want. This is extremly convenient in development mode. And it is very easy to turn off.

/assets/active_admin.js?body=1 # returns an empty file

It's ok. There is no any js code in active_admin.js. Only require directives. They trasnsforms to separate script tags and pure js code stays in manifest file. If you write some js in your active_admin.js you'll see it there

[seanlinsley]

It doesn't work how I'd expect because:

• it keeps and loads empty files like active_admin.js
• except they're not empty. You can still access the full, compiled version simply by removing body=1 from the URL.

Do you know why the body=1 thing works like it does?

[tank-bohr]

This is sprockets feature

See http://stackoverflow.com/questions/7820333/rails-3-assets-add-body-1

You can see this parameter used here:
https://github.com/sstephenson/sprockets/blob/master/lib/sprockets/server.rb#L47
https://github.com/sstephenson/sprockets/blob/master/lib/sprockets/base.rb#L372

[seanlinsley]

Thanks for abiding my laziness :]

Looks good. It'll be much easier to debug Javascript in the browser with this change. Thanks! 🐱

[tank-bohr]

Thank you :)