Remove deprecated settings and code #2165
Conversation
| end | ||
| name = namespace.root? ? nil : namespace.name | ||
| scope name, :as => name, :module => name do | ||
| root :to => namespace.root_to |
There was a problem hiding this comment.
I used scope instead of namespace because of rails/rails#10456
|
Okay, this is ready for 👀 |
|
Nevermind. All the deprecation warnings you get when running the test suite really bug me, so I removed them! This isn't working quite yet. |
| end | ||
| name = namespace.root? ? nil : namespace.name | ||
| namespace name, :module => name do | ||
| root :to => namespace.root_to |
There was a problem hiding this comment.
Hmm, perhaps I should use the old format after all...
if namespace.root?
root :to => namespace.root_to
else
namespace namespace.name do
root :to => namespace.root_to
end
end
|
Note to self: remove deprecated methods in the form builder. |
| end | ||
| it "should route the admin dashboard" do | ||
| get('/admin').should route_to 'admin/dashboard#index' | ||
| get('/').should route_to 'admin/dashboard#index' |
There was a problem hiding this comment.
Why does / route to the admin dashboard in this spec?
There was a problem hiding this comment.
That's a good question. I just threw that in there because that's what the test environment is giving me.
|
@daxter - Other than the tests failing on Rails 3.0 & my one comment, this looks great. |
|
I'm gonna take another stab at those tests... it feels weird just removing them and not putting something in their place. BTW the Rails 3.0 test errored out before it had a chance to fail. Travis recently introduced a "rerun" feature, so I'm rerunning that instance right now. |
|
Okay... I spent way too long trying to get a set of tests pass that weren't that important anyway. It didn't pan out, though, because of the way we inject our routes into the host app. Specifically, since the earliest defined routes take precedence, and we just keep on adding extra routes when we call |
Same behaviour, save that all actions now support multiple HTTP verbs. Removes outdated test from #780
…logic Remove deprecated settings and code
Things removed:
ActiveAdmin.default_namespace=>ActiveAdmin.application.default_namespaceconfig.csv_column_separator = ';'=>config.csv_options[:col_sep] = ';'default_sort_order=> ??