[1845] prevent assets from being registered multiple times #2139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 25, 2013
| end | ||
|
|
||
| it "should clear all existing stylesheets" do | ||
| MockRegistration.register_stylesheet "active_admin.css" | ||
| MockRegistration.stylesheets.length.should == 1 | ||
| MockRegistration.clear_stylesheets! | ||
| MockRegistration.stylesheets.length.should == 0 | ||
| MockRegistration.stylesheets.length.should be_empty |
There was a problem hiding this comment.
Think you want the following instead, as this spec fails:
MockRegistration.stylesheets.should be_emptyThere was a problem hiding this comment.
haha, yes I did.
JavaScript and CSS registrations are now stored inside a Set and a Hash, respectively, to ensure that no duplicates are created.
|
Okay, passing now. Look good to you @macfanatic? |
|
Love it. This was actually one of the first, if not the first, bits of code I contributed to AA. :) |
macfanatic
added a commit
that referenced
this pull request
Apr 26, 2013
[1845] prevent assets from being registered multiple times
|
Oh yeah how about that! Have you used a Set before? I ❤️ them cause they give you performance and uniqueness. A Set is stored as a Hash where for each element the key is your value, and the value is |
|
I've seen set, but didn't know why you would use one over a Hash. |
|
For practical purposes, a Set is an Array with guaranteed uniqueness. It behaves just like an Array, it's just that the back-end object that everything is stored in is a Hash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript and CSS registrations are now stored inside a Set and a
Hash, respectively, to ensure that no duplicates are created.
For #1845