-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code sample indentation in arbre documentation #2083
Conversation
Yeah, I just noticed the new documentation. Which I really appreciate. I've learned a lot of ActiveAdmin tricks by reading through the internals and other examples, but this documentation is nice to have. I also just realized that although I fixed the indentation of code samples, I didn't do anything to the headers, which also look like they might need some adjusting... |
Yes, that file is absolutely terrible. If you could fix it up some more, I'd really appreciate it :) |
@daxter Actually, the hierarchy is pretty sane. I'm not really sure what to do with the headings... |
So, how do I render the documentation to test my changes? |
@daxter That should do it ^^^^^ |
ug, I keep on forgetting to |
Right now the heading hierarchy is:
I would:
|
@daxter Updated per your suggestions |
Cool. This makes a huge difference to readability. Thank ya! |
The tab-style indentation in
docs/12-arbre-components.md
makes for not-so-pretty code samples.This pull-request changes tabs in to 2 spaces. Except for the first tab, which needs to be 4 spaces for code samples.