Cucumber cleanup #2015
Merged
Cucumber cleanup #2015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
all green 🍀 |
+ tests changed to expect the User's full name, instead of their username + added `display_name` to Post class in rails template application + refactored the rails template generator so it's actually readable by humans
|
I had to rebase on the current upstream master, as there were conflicts with the changes in #2034. |
|
There was one file I hadn't gotten to yet, hence there being a remaining TODO in the diff. |
|
Looked through everything but didn't pay attention to the comment on that. Everything else looked good & tests pass, so feel free to refactor even more later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it needed doing.