coffeescript constructors should not call return

[ronen]

coffeescript release 1.5.0 forbids explicit return statements in constructors. When used with the latest coffeescript, these two files now get compilation errors.

But the return statements in these two files were simply returning @, which is superfluous anyway. Deleted them and all seems good.

[seanlinsley]

@ronen, when you fix problems you really should link to the related issue (#1773) to let people know about it! I opened a PR not long after yours because it didn't look like anyone had handled it.

[ronen]

@daxter sorry, i didn't know about #1773 or i would certainly have referenced it.

[jviney]

+1 Fixes coffeescript-1.5.0 compatibility for me.

[seanlinsley]

@chourobin can you please remove that list of gems? It's really polluting this PR. The workaround is to backport coffee-script-source to 1.4.0 in your Gemfile.

@ronen don't sweat it :)

[miclovich]

Do we need a workaround by downgrading coffee-script-source, we could just remove return in the files of the culprits?

[macfanatic]

@gregbell - Do you have any idea why the return statements were in there in the first place? Appears that everything is working fine for me with the return statements commented out, but want to be a bit cautious on this one.

[seanlinsley]

@macfanatic I haven't looked through the commit history of AA's CoffeeScript files, but just in general it's very convoluted and IMO backwards. I wouldn't be surprised if someone used an automated tool to convert the codebase from JavaScript, or otherwise didn't very well understand CoffeeScript.