Just fixed paths to devise unlocks view

[Bishop]

No description provided.

[seanlinsley]

I've never used locks & unlocks with Devise...

• What exactly does this fix?
• What's the default configuration for Devise unlocks in relation to Active Admin?

Also, could you add a newline to the bottom of the view template file?

[Bishop]

https://github.com/plataformatec/devise:

Lockable: locks an account after a specified number of failed sign-in attempts (default 20). Can unlock via email or after a specified time period.

It is one of features, that disabled by default. It should be enabled by hand (both in model and in migration). From default devise migration:

      ## Confirmable
      # t.string   :confirmation_token
      # t.datetime :confirmed_at
      # t.datetime :confirmation_sent_at
      # t.string   :unconfirmed_email # Only if using reconfirmable

      ## Lockable
      # t.integer  :failed_attempts, :default => 0 # Only if lock strategy is :failed_attempts
      # t.string   :unlock_token # Only if unlock strategy is :email or :both
      # t.datetime :locked_at

      ## Token authenticatable
      # t.string :authentication_token

I think it is useful feature for admin interface. And I found corresponding view in ActiveAdmin source. Link to this page shows in /app/views/active_admin/devise/shared/_links.erb automaticaly. But this view doesn't renders. I have changed this view like other active_admin/devise views and I have added controller for devise renders this view.

/app/views/active_admin/devise/shared/_links.erb :

<%- if devise_mapping.confirmable? && controller_name != 'confirmations' %>
  <%= link_to t('active_admin.devise.links.resend_confirmation_instructions'), new_confirmation_path(resource_name) %><br />
<% end -%>

<%- if devise_mapping.lockable? && resource_class.unlock_strategy_enabled?(:email) && controller_name != 'unlocks' %>
  <%= link_to t('active_admin.devise.links.resend_unlock_instructions'), new_unlock_path(resource_name) %><br />
<% end -%>

There is confirmable logic also. I don't know, do you need it in active_admin.

[seanlinsley]

BTW, you can reforge your initial commit to include that newline (keeps AA's commit history clean)

git reset HEAD~1 # undoes the newline commit, putting its changes in your working directory
git add app/views/active_admin/devise/unlocks/new.html.erb
git diff # just to confirm
git commit --amend # rewrites your original commit, including any changes that have been staged
git push origin --force

[Bishop]

Done.