Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make download_links to a global and namespaced config var #1908

Closed
wants to merge 4 commits into from
Closed

Make download_links to a global and namespaced config var #1908

wants to merge 4 commits into from

Conversation

dmasur
Copy link
Contributor

@dmasur dmasur commented Feb 8, 2013

As requested in #1538

The download_links are now configurable as global and namespaced config variable.

With Featuretests and green for major rails versions.

@seanlinsley
Copy link
Contributor

Looks good

@macfanatic
Copy link
Contributor

Do you mind adding a bit of documentation to the doc at the bottom of the file for us?

https://github.com/gregbell/active_admin/blob/master/docs/3-index-pages.md

@dmasur
Copy link
Contributor Author

dmasur commented Mar 4, 2013

Something like that?

@seanlinsley
Copy link
Contributor

Could you squash all those commits together? It's really simple with git rebase -i. Here's some more info.

@macfanatic
Copy link
Contributor

Mention how to disable it globally, like in your cuke, and wrap that last commit into one, & we're good to go.

ie,

git reset --soft HEAD^
# make my last requested change here
git add docs/3-index-pages.md
git commit --amend
git push origin +1538-global-download-links

@dmasur
Copy link
Contributor Author

dmasur commented Mar 5, 2013

Sry I tried it, but get some merge conflicts that i am not able to solve. Can you rebase this for me?
It would be great if you can tell me the steps how to do it.

@macfanatic
Copy link
Contributor

Sure, I'll get this cleaned up & merged in.

@macfanatic
Copy link
Contributor

This has been merged into master.

@macfanatic macfanatic closed this Mar 5, 2013
@seanlinsley
Copy link
Contributor

For posterity, this is the commit: d35f6e9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants