-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make download_links to a global and namespaced config var #1908
Conversation
Looks good |
Do you mind adding a bit of documentation to the doc at the bottom of the file for us? https://github.com/gregbell/active_admin/blob/master/docs/3-index-pages.md |
Conflicts: lib/active_admin/application.rb
Something like that? |
Could you squash all those commits together? It's really simple with |
Mention how to disable it globally, like in your cuke, and wrap that last commit into one, & we're good to go. ie, git reset --soft HEAD^
# make my last requested change here
git add docs/3-index-pages.md
git commit --amend
git push origin +1538-global-download-links |
Sry I tried it, but get some merge conflicts that i am not able to solve. Can you rebase this for me? |
Sure, I'll get this cleaned up & merged in. |
This has been merged into master. |
For posterity, this is the commit: d35f6e9 |
As requested in #1538
The download_links are now configurable as global and namespaced config variable.
With Featuretests and green for major rails versions.