Use normal variable name over _ when block variable is used #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,7 +79,7 @@ def build_table_header(col) | |||
| def build_table_body | |||
| @tbody = tbody do | |||
| # Build enough rows for our collection | |||
| @collection.each{|_| tr(:class => cycle('odd', 'even'), :id => dom_id(_)) } | |||
| @collection.each{|e| tr(:class => cycle('odd', 'even'), :id => dom_id(e)) } | |||
There was a problem hiding this comment.
You might want to use elem instead of e to make it a bit more explicit
There was a problem hiding this comment.
If that would be preferred, I can change it to that
_ is generally used and intented for ignoring options. It allows for having multiple _ parameters for example. The behavior of this is also not consistent across at least Ruby 1.8 and 1.9, where on 1.8 it is the value nil, on 1.9 it works somewhat like a regular name. To avoid all this confusion, this commit changes it to use a regular name.
|
I've updated the pull request with the new name 'elem' |
macfanatic
added a commit
that referenced
this pull request
Mar 5, 2013
Use normal variable name over _ when block variable is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_ is generally used and intented for ignoring options. It allows for
having multiple _ parameters for example. The behavior of this is also
not consistent across at least Ruby 1.8 and 1.9, where on 1.8 it is the
value nil, on 1.9 it works somewhat like a regular name.
To avoid all this confusion, this commit changes it to use a regular
name. This also fixes a bug running in Rubinius 1.9 mode (this behavior needs to be fixed there as well).