Update lib/active_admin/form_builder.rb #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kerberos Could you write some tests? |
|
@ptn Could you test this PR against your app? |
|
Yes sir, although it might have to wait until tomorrow. |
|
@pcreux sure, i'm gonna try to write some test later today. |
jpmckinney
pushed a commit
that referenced
this pull request
Nov 7, 2012
Update lib/active_admin/form_builder.rb
|
Merged, though tests are still appreciated. |
|
FWIW, I just tested this and it did work. I'm trying to write tests, but the code is a bit meta and I'm having trouble. Will submit a PR if I can. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixs for issue #1311