-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow a blacklist listing filters #1609
Conversation
I don't know about the name |
I think the naming is fine, unless consensus around some other name is reached, we should just leave it. |
It's not bikeshedding. |
I totally agree with @jpmckinney |
looks like consensus has been reached, awesome. remove_filter it is. @tracedwax got a chance to update the pr? |
We want to preserve active generation of filters, while opting out of certain filters, for example associations. Sometimes associations can be prohibitively large, for example when there are 100,000 users and several models which belong_to :user. That filter would have too many items for the list to display correctly, and was causing serious performance issues.
Done - changed the naming to remove_filter as discussed. |
Allow a blacklist listing filters
Merged, thanks! |
We want to preserve active generation of filters, while
opting out of certain filters, for example associations.
Sometimes associations can be prohibitively large, for
example when there are 100,000 users and several models
which belong_to :user. That filter would have too many
items for the list to display correctly, and was causing
serious performance issues.
Example: