Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing rule in consumer proguard rule file #685

Closed
tdtran opened this issue Dec 7, 2021 · 1 comment · Fixed by #686
Closed

Missing rule in consumer proguard rule file #685

tdtran opened this issue Dec 7, 2021 · 1 comment · Fixed by #686
Assignees
Labels
bug Something isn't working confirmed
Milestone

Comments

@tdtran
Copy link

tdtran commented Dec 7, 2021

The following should be added to the consumer proguard rule file

-keepclassmembers class org.greenrobot.eventbus.util.ThrowableFailureEvent {
    <init>(java.lang.Throwable);
}

The current rule set only have keepclassmembers for subclasses of ThrowableFailureEvent, not for ThrowableFailureEvent class itself

This problem is not exactly new. Before version 3.3.0 we were supposed to add the rules to our project proguard rule file ourself as advised by EventBus README which also forgot the rule for ThrowableFailureEvent class. One user reported the issue here

#131 (comment)

We had to do the same for our projects.

@tdtran tdtran changed the title Broken proguard rule file Missing rule in consumer proguard rule file Dec 7, 2021
@greenrobot-team
Copy link
Collaborator

Thanks for reporting! The existing rule can also be replaced by yours as AsyncExecutor does not seem to require using a subclass of ThrowableFailureEvent. It's rather just the default.

Instead it requires any class with a constructor that takes a Throwable as single parameter. Should also update docs with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants