-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClinicalTrials.gov website updates #1210
Comments
Oh no! I'm definitely interested in keeping an eye on this. |
Also noting the URL format used for resolution: https://clinicaltrials.gov/ct2/show/NCT04619628. This URL currently redirects to the classic view, although I imagine eventually it which switch to redirect to the new view if classic is retired. I think updating Bioregistry is a good idea. I'll make a PR for that.
This is the bigger worry IMO, so good to keep in mind when we upgrade the bioregistry version in Manubot, and perhaps to test so we can report any bugs to Zotero beforehand. |
One solution for upgrading manubot is to simply generate URLs that are https://bioregistry.io/:, then you don't have to update this in manubot ever since this can be handled upstream |
Directly testing the classic and new website formats indicates there will be problems. I'm assuming the Zotero translator is used for both.
This trial ID isn't even the best example because it doesn't set all the metadata that zotero/translators#2153 added support for, like the creators. |
refs greenelab/covid19-review#1210 Two changes (one per commit) that should be treated as separate (I can remove either of the changes from this PR based on review).
I opened a similar issue for the Zotero translator. I don't know enough Javascript to make the updates myself. zotero/translators#3069 |
Good news on this, Zotero contributors responded to my issue and updated the |
Nice! I just updated the Manubot translation-server to zotero/translators@28f344cd, which includes zotero/translators@edde701. But I'm still getting the same result as above for |
It seems like your translation-server update worked. I tested another URL from the test case of a recent commit zotero/translators@aa7d6a2
The output matches at first glance. The output does not match the classic clinical trials URL test case:
For example, the creators are empty. |
ClinicalTrials.gov updated their website (announcement). I'm not sure whether the Zotero citation infrastructure that Manubot relies on will be stable. The classic website will be retired.
Here's an example of the new and classic sites:
I believe we need to update https://github.com/biopragmatics/bioregistry/ and then the Manubot package to update these URLs. Is that correct @dhimmel?
The text was updated successfully, but these errors were encountered: