Check for wrong names or values in the script_xrefs parameters #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please let me know if I should check for other symbols. |
cfi-gb
reviewed
Feb 9, 2021
There was a problem hiding this comment.
There are a few typos found:
$ codespell -e CHANGELOG.md nasl/lint.c
nasl/lint.c:552: otherwhise ==> otherwise
nasl/lint.c:639: Limite ==> Limit
nasl/lint.c:642: otherwhise ==> otherwise
Code changes needs to be reviewed and approved by a @greenbone/gvm-dev team member.
As include files does not have description block.
ArnoStiefvater
approved these changes
Feb 9, 2021
2 tasks
cfi-gb
approved these changes
Feb 9, 2021
thanks to you for pointing them out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Check for wrong names or values in the script_xrefs parameters.
Why:
Comma is not allowed and should be checked.
How:
Add a comma in an xrefs in the description block and check it with openvas-nasl-lint
Checklist: