Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

21.4.4: confusion about newly introduced libnet dependency #1043

Closed
tgurr opened this issue Feb 23, 2022 · 1 comment · Fixed by #1045
Closed

21.4.4: confusion about newly introduced libnet dependency #1043

tgurr opened this issue Feb 23, 2022 · 1 comment · Fixed by #1045
Assignees
@jjnicola
Labels
bug Something isn't working

Comments

@tgurr
Copy link

tgurr commented Feb 23, 2022

nasl/CMakeList.txt has ${LIBNET_LDFLAGS} in target_link_libraries but is missing the whole find_library depedency check from 7503c8c.

additionally it seems to carry 41729b2 which implicates the libnet dependency was already removed again with 6d3a797, however git main branch also still has the ${LIBNET_LDFLAGS} in target_link_libraries so apparently not completely?

Consider me confused.
@tgurr tgurr added the bug Something isn't working label Feb 23, 2022
@jjnicola jjnicola self-assigned this Feb 24, 2022
@jjnicola
Copy link
Member

Hey @tgurr !
thanks for reporting. I added libnet and then It was not required anymore with the next PR. It seems I forgot to clean the cmake. Will take a look.

@jjnicola jjnicola mentioned this issue Feb 24, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjnicola jjnicola

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change: remove unnecessary variable in nasl/CMakeLists.txt jjnicola/openvas-scanner
2 participants
@tgurr @jjnicola