From 146ab811a7db3c0d10a8abbbfe963e31ce5c9600 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Ricks?= Date: Fri, 21 Sep 2018 12:32:38 +0200 Subject: [PATCH 1/3] Require nodejs 8.x nodejs >= 8 is required for running the tests which use jest-styled-components now. Therefore set a required nodejs version in package.json and update the required version in the CMakeLists.txt file. --- gsa/CMakeLists.txt | 2 +- gsa/package.json | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/gsa/CMakeLists.txt b/gsa/CMakeLists.txt index 6bc19406e5..7b02288218 100644 --- a/gsa/CMakeLists.txt +++ b/gsa/CMakeLists.txt @@ -23,7 +23,7 @@ # along with this program; if not, write to the Free Software # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. -find_package (Node 6.0 REQUIRED) +find_package (Node 8.0 REQUIRED) find_package (Yarn QUIET) set (GSA_BUILD_DIR ${CMAKE_CURRENT_SOURCE_DIR}/build) diff --git a/gsa/package.json b/gsa/package.json index 57eb33acdb..e9907f0f65 100644 --- a/gsa/package.json +++ b/gsa/package.json @@ -16,6 +16,9 @@ "author": "Björn Ricks ", "license": "GPL-2.0+", "main": "src/index.js", + "engines": { + "node" : ">=8.0" + }, "eslintConfig": { "extends": "react-app" }, From 6958ea009d609c6d17db600a139d45805c531c8f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Ricks?= Date: Fri, 21 Sep 2018 12:34:55 +0200 Subject: [PATCH 2/3] Update INSTALL for new node version Debian stable is also stretch now. --- INSTALL.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/INSTALL.md b/INSTALL.md index edd137bf9d..7247fc82aa 100644 --- a/INSTALL.md +++ b/INSTALL.md @@ -86,7 +86,7 @@ Compiling Greenbone Security Assistant GUI ------------------------------------------ Prerequisites for using the GUI: -* node.js >= 6.0 +* node.js >= 8.0 * Either yarn or npm. yarn is faster and more reliable, but younger. On Debian Stretch node.js is too old. Follow these steps for a @@ -104,7 +104,7 @@ $ echo "deb https://dl.yarnpkg.com/debian/ stable main" | sudo tee /etc/apt/sour ``` ```sh $ curl --silent --show-error https://deb.nodesource.com/gpgkey/nodesource.gpg.key | sudo apt-key add - -$ echo "deb https://deb.nodesource.com/node_6.x jessie main" | sudo tee /etc/apt/sources.list.d/nodesource.list +$ echo "deb https://deb.nodesource.com/node_8.x stretch main" | sudo tee /etc/apt/sources.list.d/nodesource.list ``` ```sh From 4cf21cf3869e909aeacb1b52ed3f1e29c766f45c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Ricks?= Date: Fri, 21 Sep 2018 12:35:37 +0200 Subject: [PATCH 3/3] Remove INSTALL section about nodejs-legacy link This shouldn't be required anymore. --- INSTALL.md | 6 ------ 1 file changed, 6 deletions(-) diff --git a/INSTALL.md b/INSTALL.md index 7247fc82aa..1e4c96b084 100644 --- a/INSTALL.md +++ b/INSTALL.md @@ -115,12 +115,6 @@ $ sudo apt-get update $ sudo apt-get install nodejs yarn ``` -When using npm you might need to install the additional nodejs legacy symlink. - -```sh -$ sudo apt-get install nodejs-legacy -``` - Developing Greenbone Security Assistant GUI -------------------------------------------